Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add internal terminology defining and routines #7299

Merged
merged 2 commits into from
Feb 21, 2017
Merged

Add internal terminology defining and routines #7299

merged 2 commits into from
Feb 21, 2017

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Feb 17, 2017

and some extra verbose output

Fixes #6531

Test Plan

  1. run with LEDGER_VERBOSE=true
  2. visit some sites, etc.
  3. go to about:preferences#payments
  4. some time later you'll see something that looks like the output below (sorry, it doesn't look "nice" in a variable-width font).
  5. verify that things look "right" according to https://github.com/brave/browser-laptop/blob/issue-6531/app/ledger.js#L22 et. seq.
    ledger client run: clientP=true delayTime=582412
              publisher  blockedP   stickyP  verified  excluded eligibleP  visibleP  contribP  duration    visits
            wikihow.com     false      true      true     false      true      true      true    117448        28
            archive.org     false     false      true     false      true      true      true     22729         8
          wikipedia.org     false     false     false     false      true      true      true     13709        10
           coindesk.com     false      true      true     false      true      true      true       841        19
           usesthis.com     false     false      true     false      true      true      true       172        10
       scotthelme.co.uk     false     false      true     false      true      true      true       130         7
             github.com     false     false     false      true      true     false     false       565         3
           facebook.com     false     false     false      true      true     false     false       546         1
             google.com     false     false     false      true      true     false     false        97         2

And some extra verbose output
@mrose17 mrose17 added this to the 0.13.5 milestone Feb 17, 2017
@mrose17 mrose17 self-assigned this Feb 17, 2017
@mrose17 mrose17 requested a review from bsclifton February 17, 2017 01:51
app/ledger.js Outdated
'contribP',
'duration', 'visits'
])
synopsis.topN().forEach((entry) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing synopsis list I've got the following error regarding this line:

TypeError: Cannot read property 'forEach' of undefined
    at run (/Users/cezaraugusto/dev/browser-laptop/app/ledger.js:1576:20)
    at Timeout.setTimeout [as _onTimeout] (/Users/cezaraugusto/dev/browser-laptop/app/ledger.js:749:47)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
process exited with code 7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cezaraugusto - good catch, fixed, thanks!

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job- this is nice 😄 Gave it a mild run and toggled sites and verified their status was updated correctly. Could definitely use some tests though...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants