Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixing unit tests #7668

Merged
merged 1 commit into from
Mar 12, 2017
Merged

Fixing unit tests #7668

merged 1 commit into from
Mar 12, 2017

Conversation

NejcZdovc
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7667

Auditors

@bsclifton @aekeus

Test Plan

  • unit test should be green

@NejcZdovc
Fixing unit tests
19647a8 
Resolves brave#7667

Auditors:
@bsclifton @aekeus

Test Plan:
- unit test should be green
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Mar 12, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
aekeus
aekeus approved these changes Mar 12, 2017
View reviewed changes
Copy link
Member

@aekeus aekeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NejcZdovc for fixing this. I should have caught it in my original commit. Appreciated.

@NejcZdovc NejcZdovc merged commit f43488a into brave:master Mar 12, 2017
bsclifton
bsclifton reviewed Mar 12, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton left review comments

@aekeus aekeus aekeus approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @aekeus @bsclifton