Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improvement of buttons on TorrentViewer #7679

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Improvement of buttons on TorrentViewer #7679

merged 1 commit into from
Mar 14, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 13, 2017

Test Plan:

  1. Visit https://codepen.io/ferossity/full/qaezaB/
  2. Open any link on the page in a new tab
  3. Make sure there is a gap between the buttons on the header

Description

  • Removed redundant rules, adding "primaryButton" class
  • Removed float:right by aligning the buttons on the js file

Fixes #6735

Auditors: @cezaraugusto

screenshot 2017-03-13 17 44 29

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@luixxiul luixxiul added misc/button polish Nice to have — usually related to front-end/visual tasks. labels Mar 13, 2017
@luixxiul luixxiul self-assigned this Mar 13, 2017
@luixxiul luixxiul added this to the 0.13.6 milestone Mar 13, 2017
border-bottom: 2px solid @braveOrange;
box-shadow: @buttonShadow;
color: white;
.mainButton {;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; was added by accident. I'll remove it soon

- Removed redundant rules, adding "primaryButton" class
- Removed float:right by aligning the buttons on the js file

Fixes #6735

Auditors:

Test Plan:
1. Visit https://codepen.io/ferossity/full/qaezaB/
2. Open any link on the page in a new tab
3. Make sure there is a gap between the buttons on the header
@luixxiul
Copy link
Contributor Author

Updated, ready for reviewing

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
misc/button polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants