Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add numbered session option for menu #7684

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Add numbered session option for menu #7684

merged 1 commit into from
Mar 15, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 13, 2017

Auditors: @bbondy

Follow-up of #7367
Fix #7376

Test Plan:

  • You should be able to switch between sessions using:
    • longpress on newtab's + menu
    • hambuger menu
    • using cmd+shift+s or ctrl+shift+s shortcut

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 13, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 13, 2017
@bbondy
Copy link
Member

bbondy commented Mar 15, 2017

Great stuff. ++.

I'm not sure what the best UX is for the shortcut key of command+shift+s but this is a definite improvement for the overall UX of session tabs, so merging.

@bbondy bbondy merged commit 10fe466 into brave:master Mar 15, 2017
@bsclifton
Copy link
Member

😻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants