Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Instantly show newTab title instead of location #7754

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Instantly show newTab title instead of location #7754

merged 1 commit into from
Mar 17, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 16, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bbondy

Fix #7724

Test Plan: covered by automated test

npm run test -- --grep="shows new tab title instead of about:newtab"

QA steps:

  1. Open a new tab by any means (shortcut, plus button, menu)
  2. Newtab title should be "New Tab" instead of "about:newtab"

Auditors: @bbondy

Fix #7724

Test Plan: covered by automated test
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out (before and after these changes)- works great 😄 Thanks for doing the test too!

@bsclifton bsclifton merged commit 903cfea into brave:master Mar 17, 2017
@cezaraugusto cezaraugusto deleted the hotfix/7724 branch July 25, 2017 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants