Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove top:1px from .urlbarForm > * #7807

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Remove top:1px from .urlbarForm > * #7807

merged 1 commit into from
Mar 22, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 21, 2017

Closes #7805

The fix is no longer necessary as the header design became flat thanks to #7546 and #7739

Auditors:

Test Plan: make sure the URL bar looks like #7805 (comment)

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Closes #7805

The fix is no longer necessary as the header design became flat thanks to #7546 and #7739

Auditors:

Test Plan:
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Mar 21, 2017
@luixxiul luixxiul self-assigned this Mar 21, 2017
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@luixxiul luixxiul merged commit dbe5dac into brave:master Mar 22, 2017
@luixxiul luixxiul deleted the remove-urlbarForm-hacks branch March 22, 2017 02:45
@luixxiul luixxiul added this to the 0.14.0 milestone Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed vertical center display of URL bar (Remove "top: 1px" from .urlbarForm>*)
2 participants