Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds fingerprint and scripts to the lion badge count #7900

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Adds fingerprint and scripts to the lion badge count #7900

merged 2 commits into from
Mar 27, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 26, 2017 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7886

Auditor

@bsclifton

Test Plan

  • Visit icloud.com with fingerprint enabled
  • badge count should be 1

@NejcZdovc
Adds fingerprint and scripts to the lion badge count
d645afe 
Resolves brave#7886

Auditors: @bsclifton

Test Plan:
- Visit icloud.com with fingerprint enabled
- badge count should be 1
@NejcZdovc NejcZdovc added this to the 0.14.0 milestone Mar 26, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 26, 2017
bsclifton
bsclifton approved these changes Mar 27, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some unit tests 😄 Also manually tested, looks great ++

@bsclifton bsclifton merged commit 9058d8f into brave:master Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/shields
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @bsclifton @luixxiul