This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Use ledger-client@0.9.8 to support excludeOnly option #7969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This queries the leveldb file directly and spot checks a few known includes/excludes. Auditors: @mrose17, @bbondy, @alexwykoff Test Plan: 1. Make sure you have latest npm packages installed (from this PR) 2. In window 1, run `npm run watch-all`. 3. In window 2, run LEDGER_VERBOSE=1 LEDGER_RULES_TESTING=1 npm start` 4. Wait for ledger to finish downloading the entries (took me 6 minutes, may take more/less) 5. When finished, close the browser 6. In window 2, run `npm run test -- --grep="smoketest for our exclusion list"`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7940
git rebase -ito squash commits (if needed).Test Plan:
Verify that certain sites are excluded and other aren't. consulting with @bsclifton on this.