Fixes deprecated prop types #8153

NejcZdovc · 2017-04-09T16:32:03Z

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Resolves #8152

bbondy · 2017-04-10T02:27:43Z

Could you rebase this? Thanks!

bbondy · 2017-04-10T02:50:33Z

I'd be ok even just removing prop types in favour of future work with flow. Happy to accept this conversion PR though either way once rebased.

NejcZdovc · 2017-04-10T08:22:24Z

@bbondy let's leave this types for now and when we move to flow, we can remove it. Created an issue to track this #8168

@bsclifton

Resolves brave#8152 Auditors: @bsclifton @bbondy Test Plan:

NejcZdovc · 2017-04-10T08:26:52Z

@bbondy rebased

bsclifton

++

NejcZdovc added dev-setup PR/needs-QA-attention ☕ labels Apr 9, 2017

NejcZdovc added this to the 0.14.2 milestone Apr 9, 2017

NejcZdovc self-assigned this Apr 9, 2017

NejcZdovc requested review from bbondy and bsclifton April 9, 2017 16:32

luixxiul added the PR/needs-rebase ۞ label Apr 10, 2017

cndouglas changed the title ~~Fixes depricated prop types~~ Fixes deprecated prop types Apr 10, 2017

Fixes depricated prop types, now we use separate npm package

e9e3f1d

Resolves brave#8152 Auditors: @bsclifton @bbondy Test Plan:

NejcZdovc force-pushed the hotfix/#8152-types branch from 1695bbc to e9e3f1d Compare April 10, 2017 08:25

NejcZdovc removed the PR/needs-rebase ۞ label Apr 10, 2017

bsclifton added QA/no-qa-needed release-notes/exclude and removed PR/needs-QA-attention ☕ labels Apr 10, 2017

bsclifton approved these changes Apr 10, 2017

View reviewed changes

bsclifton merged commit 73762de into brave:master Apr 10, 2017

Provide feedback