This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix copy to clipboard tooltip #8201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Apr 10, 2017
| @@ -37,9 +37,10 @@ class ClipboardButton extends React.Component { | |||
| <span className={css( | |||
| styles.doneLabel, | |||
| this.state.visibleLabel && styles.visible | |||
| )} onAnimationEnd={this.onAnimationEnd} data-l10n-id='copied'>Copiesd!</span> | |||
| )} onAnimationEnd={this.onAnimationEnd} data-l10n-id='copied'>Copied!</span> | |||
There was a problem hiding this comment.
Why do we have english text hardcoded?
NejcZdovc
reviewed
Apr 10, 2017
| @@ -37,7 +37,7 @@ class ClipboardButton extends React.Component { | |||
| <span className={css( | |||
| styles.doneLabel, | |||
| this.state.visibleLabel && styles.visible | |||
| )} onAnimationEnd={this.onAnimationEnd} data-l10n-id='copied'>Copied!</span> | |||
| )} onAnimationEnd={this.onAnimationEnd} data-l10n-id='copied'></span> | |||
There was a problem hiding this comment.
Can you please change this to data-l10n-id='copied' />
|
@NejcZdovc I fixed everything you pointed out and squashed the commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Copy to clipboardtooltip is shown.Description
Fixes #8199
git rebase -ito squash commits (if needed).