Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

include and locale-ready webtorrent description #8209

Merged
merged 1 commit into from
Apr 10, 2017
Merged

include and locale-ready webtorrent description #8209

merged 1 commit into from
Apr 10, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Apr 10, 2017

Test Plan:

  • Go to about:extensions
    • Webtorrent description should be Uses WebTorrent to display torrents directly in the browser. Supports torrent files and magnet links.
  • Go to preferences -> extensions
    • Webtorrent description should be Uses WebTorrent to display torrents directly in the browser. Supports torrent files and magnet links.
  • Other extensions descriptions on both places shouldn't be affected

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 10, 2017

@cezaraugusto Looks good, but any reason not to include a description for Sync, Vimium at this time too?

@cezaraugusto
Copy link
Contributor Author

for Sync is basically that it's not included on extensionsTab and UI doesn't look bad on about:extensions, and for Vimium because it's not yet included. For Vimium we can address once we allow it as an option for users.

@cezaraugusto
Copy link
Contributor Author

I'll merge this as-is since it impacts UI on extTab but feel free to tag me for follow-ups regarding other extensions. btw I'm up to do for Sync as well once we have a description for that.

@cezaraugusto cezaraugusto merged commit d42842f into brave:master Apr 10, 2017
bsclifton pushed a commit that referenced this pull request Apr 11, 2017
bsclifton pushed a commit that referenced this pull request Apr 11, 2017
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants