This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Introduces unit tests for bravifyText #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
reviewed
Apr 11, 2017
| result = result.replace(/\s+/g,' ') | ||
| expected = expected.replace(/\s+/g,' ') | ||
| result = result.replace(/\s+/g, ' ') | ||
| expected = expected.replace(/\s+/g, ' ') |
There was a problem hiding this comment.
Fixing a lint error (my bad on this one- I committed from Windows which doesn't run the npm run lint prehook)
bsclifton
reviewed
Apr 11, 2017
| 'This Chrome extension is the best one in the Google Chrome store. Use Chrome today!'), | ||
| 'This Brave extension is the best one in the Brave store. Use Brave today!') | ||
| }) | ||
| it('does not replace Google', function () { |
There was a problem hiding this comment.
Added a test to make sure we don't (going forward, if this changes, etc) replace Google since valid extensions use it
bsclifton
reviewed
Apr 11, 2017
| it('does a global replace (more than one occurrence)', function () { | ||
| assert.equal(extensionsUtil.bravifyText( | ||
| 'This Chrome extension is the best one in the Google Chrome store. Use Chrome today!'), | ||
| 'This Brave extension is the best one in the Brave store. Use Brave today!') |
There was a problem hiding this comment.
since you had the /g in there, wanted to enforce that this should replace multiple types / occurrences 😄
bsclifton
reviewed
Apr 11, 2017
| assert.equal(extensionsUtil.bravifyText('Google Docs'), 'Google Docs') | ||
| }) | ||
| it('does not replace lowercase c `chrome`', function () { | ||
| assert.equal(extensionsUtil.bravifyText('Shiny chrome plated thing'), 'Shiny chrome plated thing') |
There was a problem hiding this comment.
Good call on adding these tests; I left the regex case-sensitive to avoid conflating the browser with the region of the browser sharing the same name :) Glad you did an explicit test.
|
cliftinifyCode(code) => tested_code |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated test plan
npm run unittest -- --grep="extensionsUtil bravifyText"Description
git rebase -ito squash commits (if needed).Fixes #8213