Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix sync error when default newtab site is visited #8240

Merged
merged 1 commit into from
Apr 12, 2017
Merged

fix sync error when default newtab site is visited #8240

merged 1 commit into from
Apr 12, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Apr 11, 2017

fix #8217 and refactors syncUtil/urlBarSuggestions to use common siteUtil methods

Test Plan:

  1. enable sync in a clean profile
  2. go to https://brave.com
  3. you should not see any console errors
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@diracdeltas diracdeltas added this to the 0.14.2 milestone Apr 11, 2017
@diracdeltas diracdeltas self-assigned this Apr 11, 2017
@diracdeltas diracdeltas requested review from ayumi and bbondy April 11, 2017 22:01
fix #8217 and refactors syncUtil/urlBarSuggestions to use common siteUtil methods

Test Plan:
1. enable sync in a clean profile
2. go to https://brave.com
3. you should not see any console errors
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test plan works
tests pass
sweet

yarn test -- --grep='"'^Sync'"'

@bbondy bbondy merged commit 4d1885c into master Apr 12, 2017
@cezaraugusto cezaraugusto deleted the fix/8217 branch June 21, 2017 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRASH: ledger+sync
4 participants