Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove extensions settings from advancedTab #8257

Merged
merged 1 commit into from
Apr 12, 2017
Merged

remove extensions settings from advancedTab #8257

merged 1 commit into from
Apr 12, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Apr 12, 2017

@cezaraugusto cezaraugusto added this to the 0.14.2 milestone Apr 12, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 12, 2017
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this strings from language:

  • usePDFJS
  • useTorrentViewer
  • enableExtension
  • viewInstalledExtensions
  • moreExtensionsComingSoon

And remove css for class moreExtensionsComingSoon

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

@bsclifton
Copy link
Member

@cezaraugusto if you wanted to remove the other items that @NejcZdovc mentioned, please feel free to do in a follow up

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 13, 2017

@cezaraugusto @bsclifton we need to remove this items, otherwise we have a dead code in our codebase, which is really bad 😞

cezaraugusto added a commit that referenced this pull request Apr 13, 2017
-
Removing extensions setting from advancedTab
left some l10n/style files unused leading to dead code.
Follow-up of #8257
Auditors: @NejcZdovc
Test plan: n/a

Test Plan:
@cezaraugusto cezaraugusto deleted the settings/8230 branch July 25, 2017 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants