Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Increase the tabs bar and tabsToolbarButtons height #8300

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Increase the tabs bar and tabsToolbarButtons height #8300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/renderer/components/styles/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const globalStyles = {
buttonWidth: '25px',
navbarHeight: '36px',
downloadsBarHeight: '50px',
tabsToolbarHeight: '28px',
tabsToolbarHeight: '26px',
tabPagesHeight: '7px',
bookmarksToolbarHeight: '24px',
bookmarksToolbarWithFaviconsHeight: '24px',
Expand Down Expand Up @@ -210,4 +210,6 @@ globalStyles.color.activeTabDefaultColor = globalStyles.color.chromePrimary
globalStyles.color.switchBG_on = globalStyles.color.braveOrange
globalStyles.color.statsGray = globalStyles.color.chromeText

globalStyles.spacing.tabHeight = globalStyles.spacing.tabsToolbarHeight
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually globalStyles.spacing.tabsToolbarHeight is not yet used anywhere else (as the tabs bar is yet to be refactored with Aphrodite).


module.exports = globalStyles
4 changes: 2 additions & 2 deletions app/renderer/components/styles/tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const styles = StyleSheet.create({
boxSizing: 'border-box',
color: '#5a5a5a',
display: 'flex',
height: '24px',
height: globalStyles.spacing.tabHeight,
marginTop: '0',
transition: `transform 200ms ease, ${globalStyles.transition.tabBackgroundTransition}`,
left: '0',
Expand Down Expand Up @@ -94,7 +94,7 @@ const styles = StyleSheet.create({

active: {
background: `rgba(255, 255, 255, 1.0)`,
height: '24px',
height: globalStyles.spacing.tabHeight,
marginTop: '0',
borderWidth: '0 1px 0 0',
borderStyle: 'solid',
Expand Down
4 changes: 4 additions & 0 deletions less/tabs.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
}

.tabsToolbar {
box-sizing: border-box;
background: @tabsBackground;
display: flex;
height: @tabsToolbarHeight;
Expand All @@ -127,7 +128,10 @@
}

.tabsToolbarButtons {
box-sizing: border-box;
height: @tabHeight;
padding-right: 2px;

.browserButton {
display: inline-block;
line-height: 26px;
Expand Down
3 changes: 2 additions & 1 deletion less/variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@

@navbarHeight: 36px;
@downloadsBarHeight: 60px;
@tabsToolbarHeight: 24px;
@tabsToolbarHeight: 26px;
@tabHeight: @tabsToolbarHeight;
@tabPagesHeight: 7px;
@bookmarksToolbarHeight: 24px;
@bookmarksToolbarWithFaviconsHeight: 24px;
Expand Down