Check description for __MSG_ values #8314

jonathansampson · 2017-04-13T22:10:28Z

Test Plan:

From a fresh profile, navigate to about:preferences#extensions and turn on Pocket. Once enabled, you should see no presence of _MSG in the extension's description.

PR Details:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Resolves #8307

cezaraugusto

++

Check description for __MSG_ values

35b9fba

jonathansampson added the feature/extensions label Apr 13, 2017

jonathansampson added this to the 0.14.2 milestone Apr 13, 2017

jonathansampson self-assigned this Apr 13, 2017

jonathansampson requested a review from cezaraugusto April 13, 2017 22:10

cezaraugusto approved these changes Apr 13, 2017

View reviewed changes

cezaraugusto merged commit b299cc6 into master Apr 13, 2017

srirambv mentioned this pull request Apr 13, 2017

Extensions still show __MSG__ under description after enabling #8307

Closed

cezaraugusto deleted the ext_convert-locales branch April 13, 2017 23:18

bsclifton pushed a commit that referenced this pull request Apr 14, 2017

Check description for __MSG_ values (#8314)

766b6e2

bsclifton mentioned this pull request May 2, 2017

Dashlane Password manager shows __MSG_ExtensionName__ as extension name #7683

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check description for __MSG_ values #8314

Check description for __MSG_ values #8314

jonathansampson commented Apr 13, 2017

cezaraugusto left a comment

Check description for __MSG_ values #8314

Check description for __MSG_ values #8314

Conversation

jonathansampson commented Apr 13, 2017

Test Plan:

PR Details:

cezaraugusto left a comment

Choose a reason for hiding this comment