Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moves tab related files into app folder #8348

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Moves tab related files into app folder #8348

merged 1 commit into from
Apr 17, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 16, 2017 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8347

What was done

  1. moved files from js to app folder
  2. split components to a single file per component principle
  3. updated test according to the new structure
  4. removed redundant code

Auditors

@bsclifton @cezaraugusto

Test Plan

  • test should be green

@NejcZdovc NejcZdovc added this to the 0.14.3 milestone Apr 16, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 16, 2017
@NejcZdovc NejcZdovc changed the title Moves tab related files from js to app folder, split components to a … Moves tab related files into app folder Apr 16, 2017
@NejcZdovc
Moves tab related files from js to app folder, split components to a …
f9b2a2c 
…single file per component

Resolves brave#8347

Auditors: @bsclifton @cezaraugusto

Test Plan:
- test should be green
bsclifton
bsclifton approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit f3bd6db into brave:master Apr 17, 2017
cezaraugusto
cezaraugusto reviewed Apr 17, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice split ++

@NejcZdovc NejcZdovc mentioned this pull request Apr 27, 2017
Closed
51 tasks
@petemill petemill mentioned this pull request Oct 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto left review comments

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/pinned-tabs feature/session-tabs feature/tabsbar
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.
4 participants
@NejcZdovc @cezaraugusto @bsclifton @luixxiul