Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes store logic from windowActions #8381

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 18, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8380

Auditors: @bsclifton

Test Plan:

  1. tests should be green
  2. mute a tab (click on a volume icon in a tab that is playing some music)
  3. mute a tab (right click on a tab and select it from the context menu)
  4. mute other tabs (right click on a tab and select it from the context menu)
  5. mute/un-mute whole tab page (right click on a tab page and select it from the context menu)

Resolves brave#8380

Auditors: @bsclifton

Test Plan:
- tests should be green
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 18, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 18, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton April 18, 2017 14:54
@NejcZdovc NejcZdovc mentioned this pull request Apr 18, 2017
4 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.15.1, 0.14.2 Apr 18, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Manually tested and steps worked as described. Nice cleanup 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants