Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

View page source for local files #8404

Merged
merged 1 commit into from
Apr 23, 2017
Merged

View page source for local files #8404

merged 1 commit into from
Apr 23, 2017

Conversation

romamatusevich
Copy link
Contributor

@romamatusevich romamatusevich commented Apr 19, 2017

The file uri scheme has been made allowed for view source

fix #8049

Original issue: #8049

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • Open a local HTML file with "File" > "Open File"
  • Right-click anywhere and select "View Page Source"
  • Make sure the source is opened in another tab

@cndouglas
Copy link

Thanks @romamatusevich! Unfortunately, there are conflicts because of some recent commits. Could you please resolve them?

@romamatusevich
Copy link
Contributor Author

Hello @liunkae,

The conflicts were resolved.

Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@cndouglas
Copy link

@romamatusevich Please squash the two commits. Thanks for adding tests, by the way!

The file uri scheme has been made allowed for view source

fix #8049
@romamatusevich
Copy link
Contributor Author

@liunkae, rebased the changes to have one commit only.

@bsclifton
Copy link
Member

Awesome!! 👍

Thanks for the patch @romamatusevich 😄 (and thanks @liunkae for reviewing!)

@bsclifton bsclifton merged commit 135c94f into brave:master Apr 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View page source doesn't work for local files
3 participants