Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix issue with lost tabs ordering on relaunch #8589

Merged
merged 1 commit into from
May 1, 2017
Merged

Fix issue with lost tabs ordering on relaunch #8589

merged 1 commit into from
May 1, 2017

Conversation

romamatusevich
Copy link
Contributor

@romamatusevich romamatusevich commented Apr 30, 2017 •
edited by bsclifton
Loading

Test plan

  1. Pin some tabs,
  2. Change pin order,
  3. quit, re-open
  4. tabs should be in the same order

Description

siteProps function returns an object without order field, but this field needs to apply correct custom sorting for tabs.

Fix #8543

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@romamatusevich
Fix issue with lost tabs ordering on relaunch
31e8cdd 
siteProps function returns an object without order field, but this field needs to apply correct custom sorting for tabs.

Fix #8543
@bsclifton bsclifton added this to the 0.15.2 milestone May 1, 2017
@bsclifton bsclifton self-requested a review May 1, 2017 07:54
bsclifton
bsclifton approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice fix (and great job with the tests! 😄 )

I manually tested and it works great! ++

@bsclifton bsclifton merged commit 5954ac9 into brave:master May 1, 2017
NejcZdovc added a commit that referenced this pull request May 1, 2017
@NejcZdovc
More descriptive function name (follow up of #8589)
b612b3f 
Auditors: @bsclifton

Test plan:
- npm run unittest
@rojour
Copy link

rojour commented May 4, 2017

Still not working for me...

Brave 0.15.2
rev af7ef42
Muon 2.58.9
libchromiumcontent 58.0.3029.96
V8 5.8.283.37
Node.js 7.9.0
Update Channel dev
os.platform darwin
os.release 16.6.0
os.arch x64

@bsclifton
Copy link
Member

Hi @rojour! The release we had today only updates Chromium. We should have this fix in our next version 😄 Apologies for any inconvenience

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@romamatusevich romamatusevich

Labels
feature/tabsbar QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.
3 participants
@romamatusevich @rojour @bsclifton