-
Notifications
You must be signed in to change notification settings - Fork 975
Merges tabs into frames object in windowStore #8833
Conversation
b87a773
to
dfb6327
Compare
3e1ca92
to
afca42f
Compare
afca42f
to
a35fec7
Compare
Resolves brave#8689 Auditors: @bsclifton @bbondy Test Plan: - tests should be green
a35fec7
to
a24749f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a ui.tabs
object in windowStore that you may consider dumping in a follow up. It's used for storing the preview index. For an example see:
https://github.com/brave/browser-laptop/blob/master/app/sessionStore.js#L126
Left some comments which could also be done in a follow up. Otherwise, looks great 😄 👍
)}> | ||
<Favicon | ||
isActive={this.props.isActive} | ||
paintTabs={this.props.paintTabs} | ||
tab={this.props.tab} | ||
frame={this.props.frame} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to create a reference for this (ex: const frame = this.props.frame
) and then just pass the frame={frame}
, instead of this.props.frame
each time. This way, if it changes again, you only change one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with all the stuff above; getting rid of all the duplicate this.props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will remove all this props in redux PR, so I think it's not necessary to do it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM 👍 😄
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #8689
Auditors: @bsclifton @bbondy
Test Plan:
Reviewer Checklist:
Tests