Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactors addEditBookmarkHanger and addEditBookmark into redux #8928

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 18, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8927

Auditors: @bsclifton

Test Plan:

  • Test that creating a bookmark on the bookmarks toolbar with the star button works
  • Test that creating a bookmark on the bookmarks toolbar by dragging the un/lock icon works
  • Test that creating a bookmark folder on the bookmarks toolbar works
  • Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  • Test that clicking a bookmark in the toolbar loads the bookmark.
  • Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan (copied from Wiki) works.

@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch from ca78189 to f1eb47d Compare May 18, 2017 23:04
@bsclifton bsclifton changed the title Refactors addEditBookmarHanger and addEditBookmark into redux Refactors addEditBookmarkHanger and addEditBookmark into redux May 21, 2017
@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch from f1eb47d to 485d5b0 Compare May 24, 2017 21:01
@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch from 485d5b0 to 87dd8d9 Compare May 26, 2017 21:53
@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch 2 times, most recently from 29002c0 to fcf89f1 Compare June 7, 2017 00:27
Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page
@NejcZdovc NejcZdovc force-pushed the redux/bookmarkHanger branch from fcf89f1 to cd35e14 Compare June 7, 2017 16:37
@NejcZdovc NejcZdovc merged commit bc5af54 into brave:master Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants