Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix webgl antifingerprint regression #8964

Merged
merged 1 commit into from
May 19, 2017
Merged

fix webgl antifingerprint regression #8964

merged 1 commit into from
May 19, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 19, 2017 •
edited by luixxiul
Loading

fix #8961

Test Plan:

  1. https://jsfiddle.net/bkf50r8v/13/ should show no webgl fingerprint results with 'Fingerprinting Protection' enabled
  2. https://browserleaks.com/webgl with fingerprint protection on: report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4', the image hash should be empty, all the fields under the triangle image should be empty

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas
fix webgl antifingerprint regression
0028762 
fix #8691

Test Plan:
1. https://jsfiddle.net/bkf50r8v/13/ should show no webgl fingerprint results with 'Fingerprinting Protection' enabled
2.  https://browserleaks.com/webgl with fingerprint protection on:  report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4', the image hash should be empty, all the fields under the triangle image should be empty
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 19, 2017
@diracdeltas diracdeltas self-assigned this May 19, 2017
@diracdeltas diracdeltas requested a review from luixxiul May 19, 2017 18:45
luixxiul
luixxiul approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual test plan works. "npm run test -- --grep='fingerprinting'" passes too. LGTM.

@diracdeltas diracdeltas merged commit da5b398 into master May 19, 2017
@diracdeltas diracdeltas deleted the fix/8961 branch May 19, 2017 19:33
@luixxiul luixxiul mentioned this pull request May 19, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luixxiul luixxiul luixxiul approved these changes

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.

WebGL fingerprinting is not blocked
2 participants
@diracdeltas @luixxiul