This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove adblock.less & Rename custom classNames on switchControl.js #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bbondy
reviewed
May 26, 2017
js/about/adblock.js
Outdated
| @@ -37,6 +37,7 @@ class AdBlockItem extends ImmutableComponent { | |||
| <SwitchControl id={this.props.resource.get('uuid')} | |||
| rightText={this.props.resource.get('title')} | |||
| className={`switch-${this.props.resource.get('uuid')}`} | |||
| customRightText={css(styles.adblockLists__adblockItem__switchControl)} | |||
There was a problem hiding this comment.
This name is a bit misleading for passing in styles, Maybe call it customRightTextStyle?
There was a problem hiding this comment.
I would agree. I'm fixing other custom* with this PR later.
added 2 commits
May 27, 2017 00:02
Addresses #7321 Auditors: Test Plan: 1. npm run test -- --grep='Bravery Panel'
|
I confirmed pulling the two commits to |
luixxiul
changed the title
bsclifton
pushed a commit
that referenced
this pull request
Jun 7, 2017
8 tasks
|
Not seeing the fix on 0.17.3 |
|
because the margin is this one:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customRightTextClassNameCloses #9042
Addresses #7321
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests