This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add webdriver test to noScript exceptions on compact bravery panel and apply .changeSetting #9075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #8837 Test Plan: npm run test -- --grep='does not apply exceptions from private tabs to regular tabs on compact panel'
diracdeltas
reviewed
May 28, 2017
| .waitForVisible(compactBraveryPanelSwitch) | ||
| .click(compactBraveryPanelSwitch) | ||
| .windowByUrl(Brave.browserWindowUrl) | ||
| .keys(Brave.keys.ESCAPE) |
There was a problem hiding this comment.
i think you can avoid the above by just using this.app.client.changeSetting
There was a problem hiding this comment.
this.app.client.changeSetting
ya that's the solution I have been looking for. thanks for the tip.
There was a problem hiding this comment.
Test Plan: 1. npm run test -- --grep='Bravery Panel'
luixxiul
changed the title
diracdeltas
approved these changes
Jun 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8837
Because
does not apply exceptions from private tabs to regular tabsis already complex somewhat, I'm adding another test to cover #8837 on compact bravery panel.Also I applied
this.app.client.changeSettingto the other tests with 17c2f04Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests