This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix sync duplicating folders #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #8454, particularly #8454 (comment) Test Plan: 1. Enable sync in Pyramid 0. 2. Create a folder. 3. Wait for at least 1 minute. The folder should not be duplicated. 4. Repeat the test plan from #8454 to make sure that bookmark hierarchy is preserved when syncing pyramids.
diracdeltas
commented
Jun 1, 2017
| if (action.destinationDetail) { | ||
| const sourceKey = siteUtil.getSiteKey(action.siteDetail) | ||
| const destinationKey = siteUtil.getSiteKey(action.destinationDetail) | ||
| if (action.destinationDetail) { |
There was a problem hiding this comment.
all of this code seems to assume that action.siteDetail is not a List, so i think it should go within the if block instead of outside it
bsclifton
modified the milestones:
0.17.x (Frozen, only critical adds from here),
0.18.x
bsclifton
modified the milestones:
0.16.x (Frozen, only critical adds from here),
0.17.x (Frozen, only critical adds from here)
|
Pulling into 0.16.x, per request by @alexwykoff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8454, particularly #8454 (comment)
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests