Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow suggestions from bookmark custom titles #9250

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 4, 2017

Fix #9249

Auditors: @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy self-assigned this Jun 4, 2017
@bbondy bbondy requested a review from bsclifton June 4, 2017 11:25
@luixxiul luixxiul changed the title Allow suggestions from bookoarmk custom titles Allow suggestions from bookmark custom titles Jun 4, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ this is a great addition! 😄 Can't believe we didn't already have this

@bsclifton bsclifton merged commit 6339013 into master Jun 4, 2017
@bsclifton bsclifton deleted the custom-title-suggestions branch June 4, 2017 16:43
bsclifton added a commit that referenced this pull request Jun 4, 2017
Allow suggestions from bookmark custom titles
bsclifton added a commit that referenced this pull request Jun 4, 2017
Allow suggestions from bookmark custom titles
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants