This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Converts DownloadItem and DownloadsBar into redux #9271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you creating automated tests or a manual test plan (as this is not just a copy-and-paste change)? |
|
will do after this PR is completed |
NejcZdovc
force-pushed
the
redux/downloads
branch
from
8826f43
to
baed5bb
Compare
51 tasks
NejcZdovc
force-pushed
the
redux/downloads
branch
2 times, most recently
from
a9abefc
to
f67a0ca
Compare
NejcZdovc
force-pushed
the
redux/downloads
branch
from
f67a0ca
to
e196682
Compare
bridiver
reviewed
Jun 6, 2017
| @@ -92,11 +126,11 @@ describe('downloadsBar component', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('very narrow downloads bar with items', function () { | |||
| // skipped until #9176 is merged | |||
| describe.skip('very narrow downloads bar with items', function () { | |||
There was a problem hiding this comment.
I skipped this last one, because it uses computes styles and I am working on another PR that will change that in the same version (0.18.x). So that I don't need to change it twice I will fix it in #9176 after this one is merged.
There was a problem hiding this comment.
@NejcZdovc would you please add that to #5389 for a reminder?
There was a problem hiding this comment.
it's fine as long as you won't forget.
|
just wondering why the last test is skipped, but otherwise ++ |
bridiver
approved these changes
Jun 6, 2017
NejcZdovc
force-pushed
the
redux/downloads
branch
2 times, most recently
from
5584d38
to
32bad94
Compare
Resolves brave#9260 Auditors: @bsclifton Test Plan: - download an item - check if download item is shown - check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc
force-pushed
the
redux/downloads
branch
from
32bad94
to
5a6bbfa
Compare
luixxiul
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9260
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests