Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

only call mergeProps when either the state or the props have changed #9403

Merged
merged 1 commit into from
Jun 27, 2017
Merged

only call mergeProps when either the state or the props have changed #9403

merged 1 commit into from
Jun 27, 2017

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 12, 2017 •
edited by bsclifton
Loading

let react batch updates if desired

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added this to the 0.19.x milestone Jun 12, 2017
@bridiver bridiver requested a review from NejcZdovc June 12, 2017 19:15
@bridiver bridiver removed the request for review from NejcZdovc June 13, 2017 04:28
@bridiver
Copy link
Collaborator Author

going to break this up into multiple PRs

@NejcZdovc
Copy link
Contributor

ok let me know when it's ready

@bridiver bridiver force-pushed the redux-set-state branch 16 times, most recently from 4b63566 to dffe9c1 Compare June 14, 2017 21:41
@bridiver bridiver modified the milestones: 0.18.x (Developer Channel), 0.19.x (Nightly Channel) Jun 14, 2017
@luixxiul
Copy link
Contributor

no-qa-needed?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jun 16, 2017
@bridiver bridiver requested a review from NejcZdovc June 19, 2017 23:03
@NejcZdovc NejcZdovc added QA/no-qa-needed and removed needs-info Another team member needs information from the PR/issue opener. labels Jun 20, 2017
@NejcZdovc NejcZdovc mentioned this pull request Jun 20, 2017
Closed
51 tasks
NejcZdovc
NejcZdovc approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I rebased it to the latest master, played around and didn't found any problems. Let's wait for travis to finish before merge.

bsclifton
bsclifton approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 👍

@bsclifton bsclifton merged commit a559937 into master Jun 27, 2017
@bsclifton bsclifton deleted the redux-set-state branch June 27, 2017 18:24
bsclifton added a commit that referenced this pull request Jun 27, 2017
@bsclifton
Merge pull request #9403 from brave/redux-set-state
e29680f 
only call `mergeProps` when either the state or the props have changed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@bridiver bridiver

Labels
perf QA/no-qa-needed refactoring/redux-component
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging this pull request may close these issues.
4 participants
@bridiver @NejcZdovc @luixxiul @bsclifton