Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enable importing passwords from Firefox #9433

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

evq
Copy link
Member

@evq evq commented Jun 13, 2017

Auditors: @darkdh

requires brave/muon#216
closes #9292

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will also need to remove
importer.on('add-password-form', (e, detail) => {})
since we have different implementation on muon brave/muon#216

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 14, 2017
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into one, thanks.

@NejcZdovc
Copy link
Contributor

Please add github auto-closing keyword into squashed commit

@evq evq force-pushed the feature/password-import branch from bca2a70 to d3e5792 Compare June 14, 2017 21:55
@bsclifton
Copy link
Member

Holding off on merge until Muon code is accepted

Changes look great- nice work, @evq 😄

@cezaraugusto
Copy link
Contributor

muon code was accepted, @evq could you pls rebase?

@cezaraugusto
Copy link
Contributor

also pls remove label once you do, thanks!

@evq
Copy link
Member Author

evq commented Jun 19, 2017

I rebased, waiting on a muon build to retest then I will push / remove the label

@evq evq force-pushed the feature/password-import branch from d3e5792 to baf8125 Compare June 20, 2017 01:50
@evq
Copy link
Member Author

evq commented Jun 20, 2017

@cezaraugusto I just pushed my rebased version, though I don't seem to be able to remove the label

@bridiver
Copy link
Collaborator

@evq does this have any moun dependencies?

@darkdh
Copy link
Member

darkdh commented Jun 20, 2017

muon dep has already been merged
brave/muon#216

@bridiver
Copy link
Collaborator

this needs to wait for a 4.2.x build (and update b-l 0.19) before merging. Should be ready by tomorrow

@evq
Copy link
Member Author

evq commented Jun 26, 2017

@bridiver is this good to merge since bd36f33 updated muon to 4.2.2?

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@hh-here
Copy link

hh-here commented Sep 8, 2017

I suspect that there's something I don't 'get'.
I'm running: Linux Mint 17.3 Rosa
&

Brave 0.19.6
rev 3be25d4
Preferences; Import Now; Saved Passwords => A box which tells me that it has done the biz' for both Chromium Version 59.0.3071.109
&
Firefox 54.0 (64-bit)
Then with Password Manager = Brave Built In
Security; Manage Passwords => No passwords have been saved

Q1. Are the passwords managed / saved elsewhere?
Q2. Is there something I have missed?

PS. The Firefox importing was a couple of seconds, the Chromium was 10s of seconds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import passwords from Firefox
8 participants