-
Notifications
You must be signed in to change notification settings - Fork 974
Enable importing passwords from Firefox #9433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will also need to remove
importer.on('add-password-form', (e, detail) => {})
since we have different implementation on muon brave/muon#216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all commits into one, thanks.
Please add github auto-closing keyword into squashed commit |
bca2a70
to
d3e5792
Compare
Holding off on merge until Muon code is accepted Changes look great- nice work, @evq 😄 |
muon code was accepted, @evq could you pls rebase? |
also pls remove label once you do, thanks! |
I rebased, waiting on a muon build to retest then I will push / remove the label |
d3e5792
to
baf8125
Compare
@cezaraugusto I just pushed my rebased version, though I don't seem to be able to remove the label |
@evq does this have any moun dependencies? |
muon dep has already been merged |
this needs to wait for a 4.2.x build (and update b-l 0.19) before merging. Should be ready by tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
I suspect that there's something I don't 'get'.
Q1. Are the passwords managed / saved elsewhere? PS. The Firefox importing was a couple of seconds, the Chromium was 10s of seconds. |
Auditors: @darkdh
requires brave/muon#216
closes #9292
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests