-
Notifications
You must be signed in to change notification settings - Fork 974
Converts BraveryPanel into redux component #9455
Conversation
71d5821
to
7cc456c
Compare
7cc456c
to
96abf66
Compare
96abf66
to
fd9cf39
Compare
fd9cf39
to
6b1ab82
Compare
app/common/lib/braveryPanelUtil.js
Outdated
return lastCommittedURL | ||
} | ||
|
||
const getRedirectedResources = (redirectedResources) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about the purpose of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have redirectedResources
in two level array and this function gets second level into one level.
Example:
{
google: [
'google.com',
'google.si',
],
fb: [
'facebook.si'
]
}
into
[
'google.com',
'google.si',
'facebook.si'
]
app/common/lib/braveryPanelUtil.js
Outdated
// Utils | ||
const urlParse = require('../urlParse') | ||
|
||
const getDisplayHost = (lastCommittedURL) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like something that should go in urlUtil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved
6b1ab82
to
c5a95d9
Compare
c5a95d9
to
a530e15
Compare
Resolves brave#9454 Auditors: @bsclifton @bridiver Test Plan:
a530e15
to
0597c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #9454
Auditors: @bsclifton @bridiver
Test Plan:
npm run test -- --grep='Bravery Panel'
Reviewer Checklist:
Tests