Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Converts BraveryPanel into redux component #9455

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 14, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9454

Auditors: @bsclifton @bridiver

Test Plan:

  • npm run test -- --grep='Bravery Panel'
  • check if bravery panel is opened when you click on lion head
  • check if you can toggle all checkboxes
  • check if blocking numbers are correct

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc requested review from bsclifton and bridiver June 14, 2017 11:14
@NejcZdovc NejcZdovc self-assigned this Jun 14, 2017
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 14, 2017
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from 71d5821 to 7cc456c Compare June 14, 2017 11:19
@NejcZdovc NejcZdovc mentioned this pull request Jun 14, 2017
51 tasks
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from 7cc456c to 96abf66 Compare June 14, 2017 11:59
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from 96abf66 to fd9cf39 Compare June 14, 2017 22:18
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from fd9cf39 to 6b1ab82 Compare June 19, 2017 07:48
return lastCommittedURL
}

const getRedirectedResources = (redirectedResources) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about the purpose of this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have redirectedResources in two level array and this function gets second level into one level.

Example:

{
  google: [
    'google.com',
    'google.si',
  ],
  fb: [
    'facebook.si'
  ]
}

into

[
    'google.com',
    'google.si',
    'facebook.si'
]

// Utils
const urlParse = require('../urlParse')

const getDisplayHost = (lastCommittedURL) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like something that should go in urlUtil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from 6b1ab82 to c5a95d9 Compare June 20, 2017 07:31
@NejcZdovc NejcZdovc requested a review from bridiver June 20, 2017 07:31
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from c5a95d9 to a530e15 Compare June 20, 2017 16:09
@NejcZdovc NejcZdovc force-pushed the redux/braveryPanel branch from a530e15 to 0597c77 Compare June 20, 2017 16:14
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 5b1a50a into brave:master Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants