Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Converts CheckDefaultBrowserDialog into redux component #9497

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 15, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9449

Auditors: @bsclifton @bridiver

Test Plan:

  • close brave
  • change you default browser to something else (Safari for example)
  • re-run browser
  • dialog for default browser should be displayed and you can set it to brave or cancel it

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 15, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 15, 2017
@NejcZdovc NejcZdovc requested review from bridiver and bsclifton June 15, 2017 15:14
@NejcZdovc NejcZdovc mentioned this pull request Jun 19, 2017
51 tasks
@bridiver bridiver merged commit 3cbe462 into brave:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redux component - CheckDefaultBrowserDialog
2 participants