This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Converts UpdateBar into redux component #9516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
NejcZdovc
force-pushed
the
redux/updateBar
branch
from
6589e9a to
d3a6796
Compare
bridiver
suggested changes
Jun 19, 2017
app/common/lib/updateUtil.js
Outdated
| @@ -0,0 +1,44 @@ | |||
| /* This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
this one owns appStore.updates so it would make sense as a state helper.
app/common/lib/updateUtil.js
Outdated
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| const Immutable = require('immutable') | ||
| const updateStatus = require('../../../js/constants/updateStatus') |
There was a problem hiding this comment.
we should probably merge updateStatus into this file and make it updateState
There was a problem hiding this comment.
updateStatus + updateUtil -> updateState ?
There was a problem hiding this comment.
I would leave updateStatus in constants folder, because that's what we have there. What we can do is rename this file and move it into state folder. What do you think?
NejcZdovc
force-pushed
the
redux/updateBar
branch
2 times, most recently
from
f1a862a to
bbd0f38
Compare
|
just waiting on ci to merge |
Resolves brave#9450 Auditors: @bsclifton @bridiver Test Plan:
NejcZdovc
force-pushed
the
redux/updateBar
branch
from
bbd0f38 to
5ed19e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9450
Auditors: @bsclifton @bridiver
Test Plan:
Reviewer Checklist:
Tests