Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Converts ContextMenu into redux component #9526

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 16, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9482

Auditors: @bsclifton @bridiver

Note: I could refactor really small portion of things that should be done, because the way context menu is done. This PR will enable us to refactor Main component, but not improved context menu a lot. Is a good starting point for next iterations.

Test Plan:

  • right click on a tab and check if context menu is displayed
  • try to zoom in hamburger menu

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 16, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 16, 2017
@NejcZdovc NejcZdovc requested review from bridiver and bsclifton June 16, 2017 17:34
@NejcZdovc NejcZdovc mentioned this pull request Jun 16, 2017
51 tasks
@bridiver bridiver merged commit 373e299 into brave:master Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants