Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Converts AutofillCreditCardPanel into redux component #9566

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 19, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9445

Auditors: @bsclifton @bridiver

Test Plan:

  • try to add credi card (about:autofill)
  • try to edit it
  • try to delete it

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 19, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 19, 2017
@NejcZdovc NejcZdovc requested review from bsclifton and darkdh June 19, 2017 09:50
@NejcZdovc NejcZdovc mentioned this pull request Jun 19, 2017
51 tasks
@NejcZdovc
Copy link
Contributor Author

waiting for a resolution of #9490

@NejcZdovc NejcZdovc force-pushed the redux/autofillCC branch 2 times, most recently from 80b660c to a36b916 Compare June 20, 2017 15:37
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 3db05b2 into brave:master Jun 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants