Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert reload context menu to native menu #9588

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Convert reload context menu to native menu #9588

merged 1 commit into from
Jun 22, 2017

Conversation

cndouglas
Copy link

Fixes #9571

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  1. Right click the reload button.
  2. Make sure the context menu is native.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cndouglas cndouglas added this to the 0.19.x (Nightly Channel) milestone Jun 20, 2017
@cndouglas cndouglas self-assigned this Jun 20, 2017
@cndouglas cndouglas requested a review from bsclifton June 20, 2017 00:25
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS and Windows- works great 😄 Thanks for picking this up! ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants