This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
send UPDATE instead of CREATE for sites #9614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see brave/sync#111 (comment) fix brave/sync#111 test plan: 1. create some folders and bookmarks in pyramid 0 2. create some folders and bookmarks in pyramid 1 3. create sync group in pyramid 0 and join it on pyramid 1 4. on pyramid 0, bookmark a new site. wait for it to sync over. 5. drag-and-drop the new bookmark into a folder. verify that this is synced. 6. right-click to edit an existing bookmark and change the parent folder. verify this is synced.
diracdeltas
force-pushed
the
fix/sync-folder
branch
from
June 20, 2017 22:47
0721be0
to
6a418ea
Compare
ayumi
approved these changes
Jun 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, test plan works and tests pass (npm run test -- --grep='^Syncing and clearing'
is intermittent but i think it's in master as well.)
🌵
@alexwykoff as mentioned in slack and during the triage, order is not preserved during sync yet |
SergeyZhukovsky
approved these changes
Jun 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bbondy
added a commit
that referenced
this pull request
Jun 21, 2017
send UPDATE instead of CREATE for sites
diracdeltas
pushed a commit
that referenced
this pull request
Jun 21, 2017
send UPDATE instead of CREATE for sites
@diracdeltas correct, just wanted to list it as observed so we don't need to re-test to see if we got a 2-for-1 😸 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see brave/sync#111 (comment)
fix brave/sync#111
test plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests