Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide pre-release preference, since Linux builds don't auto-update #9650

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Hide pre-release preference, since Linux builds don't auto-update #9650

merged 1 commit into from
Jun 22, 2017

Conversation

bsclifton
Copy link
Member

Automated test plan

npm run unittest -- --grep="AdvancedTab component"

Test plan

  1. Open about:preferences#advanced on a linux distibution
  2. Make sure that "update to preview release" is not there

Description

Fixes #9631

Auditors: @luixxiul, @bbondy

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton self-assigned this Jun 21, 2017
@bsclifton bsclifton added this to the 0.17.x (Beta Channel) milestone Jun 21, 2017
@bsclifton
Copy link
Member Author

NOTE: I set this as 0.17.x, but we can push to 0.18.x if we don't spin another RC and this isn't deemed a show-stopper

luixxiul
luixxiul approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton merged commit f3efaa1 into brave:master Jun 22, 2017
@bsclifton bsclifton deleted the hide-prerelease-linux branch June 22, 2017 06:30
bsclifton added a commit that referenced this pull request Jun 22, 2017
@bsclifton
Merge pull request #9650 from bsclifton/hide-prerelease-linux
3be4b9a 
Hide pre-release preference, since Linux builds don't auto-update
bsclifton added a commit that referenced this pull request Jun 22, 2017
@bsclifton
Merge pull request #9650 from bsclifton/hide-prerelease-linux
59decb1 
Hide pre-release preference, since Linux builds don't auto-update
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Jun 23, 2017
@NejcZdovc
Fixes unit tests, broken with brave#9650
7df8ce5 
Auditors: @bsclifton

Test Plan:
- unit test should pass
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9675 from NejcZdovc/hotfix/unittest-advancedTabTest
058eec2 
Fixes unit tests, broken with #9650
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9675 from NejcZdovc/hotfix/unittest-advancedTabTest
01ce539 
Fixes unit tests, broken with #9650
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9675 from NejcZdovc/hotfix/unittest-advancedTabTest
79f7014 
Fixes unit tests, broken with #9650
@ElijahLynn
Copy link

Off-topic: Do you know when Linux is planned to auto-update?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luixxiul luixxiul luixxiul approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@bsclifton bsclifton

Labels
automated-tests OS/unix-like/linux QA/no-qa-needed QA/test-plan-specified
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @ElijahLynn @luixxiul