Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds null checks to tabContentState #9673

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Adds null checks to tabContentState #9673

merged 1 commit into from
Jun 23, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 23, 2017 •
edited by bsclifton
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9663

Auditors: @bsclifton

Test Plan:

  • covered with unit tests

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added the bug label Jun 23, 2017
@NejcZdovc NejcZdovc added this to the 0.17.x (Beta Channel) milestone Jun 23, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 23, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton June 23, 2017 06:02
@NejcZdovc
Adds null checks to tabContentSate
d5f3ad1 
Resolves brave#9663

Auditors: @bsclifton

Test Plan:
- covered with unittests
@bsclifton bsclifton changed the title Adds null checks to tabContentSate Adds null checks to tabContentState Jun 23, 2017
bsclifton
bsclifton approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good- great job on the tests for this one 😄

@bsclifton bsclifton merged commit d627755 into brave:master Jun 23, 2017
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9673 from NejcZdovc/hotfix/#9663-crash
0f73004 
Adds null checks to tabContentState
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9673 from NejcZdovc/hotfix/#9663-crash
93b4940 
Adds null checks to tabContentState
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
bug
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @bsclifton