This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Revert "handle empty objects in sync DELETEs" #9726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 91ef559 and pulls in fixes from the sync implementation in 0.17.x
fix #9724
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
see #9724
bonus points: re-run test plan from brave/sync#111
Reviewer Checklist:
Tests