Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Send isSecure false instead of null when an insecure site has passive mixed content #9727

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 27, 2017

Fix #9652

If a site is already insecure and receives passive mixed content, the security state should remain insecure instead of changing to unknown.

Test Plan:

  1. go to https://video.foxbusiness.com/v/5068842750001/?#sp=show-clips
  2. click 'allow ads' so that the video will play
  3. the URL bar icon should not disappear when the video starts

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

… mixed content

Fix #9652

If a site is already insecure and receives passive mixed content, the security state should remain insecure instead of changing to unknown.

Test Plan:
1. go to https://video.foxbusiness.com/v/5068842750001/?#sp=show-clips
2. click 'allow ads' so that the video will play
3. the URL bar icon should not disappear when the video starts
@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 27, 2017
@diracdeltas diracdeltas self-assigned this Jun 27, 2017
@diracdeltas diracdeltas requested a review from darkdh June 27, 2017 00:12
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 13984b0 into master Jun 27, 2017
@bsclifton bsclifton deleted the fix/9652 branch June 27, 2017 05:15
bsclifton added a commit that referenced this pull request Jun 27, 2017
Send isSecure false instead of null when an insecure site has passive mixed content
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants