Fix chance of having a lost window #9912
Conversation
bbondy
force-pushed
the
9806
branch
3 times, most recently
from
38280c3 to
2ebeca9
Compare
|
Ready for review pls |
| // exit cleanly on signals | ||
| ['SIGTERM', 'SIGHUP', 'SIGINT', 'SIGBREAK'].forEach((signal) => { | ||
| ;['SIGTERM', 'SIGHUP', 'SIGINT', 'SIGBREAK'].forEach((signal) => { |
There was a problem hiding this comment.
Is this semi-colon intentional?
There was a problem hiding this comment.
Yeah, I think it is. Because we don't use ; and you have } in the last line and this line starts with [, so this could lead into errors
There was a problem hiding this comment.
yep it's a good practice to start lines like that with a semicolon so you don't need to worry about moved code and the preceding line of code.
| require('../../app/renderer/reducers/contextMenuReducer'), | ||
| // This should be included even in production builds since you can use | ||
| // an environment variable to show the Debug menu | ||
| require('../../app/renderer/reducers/debugReducer') |
|
|
||
| describe('sessionStore', function () { | ||
| describe('sessionStore test', function () { |
There was a problem hiding this comment.
These tests are failing for me every time
There was a problem hiding this comment.
OK just ran them again (3rd or 4th attempt). Worked great 😄 👍
Fix chance of having a lost window
|
This cherry-picked into 0.19.x without issues... but I had trouble cherry-picking into 0.18.x 😦 @bbondy can you help me resolve the conflict? |
Fix chance of having a lost window
|
merged to 0.18.x |
Fix #9806
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
npm run unittest -- --grep="sessionStoreShutdown unit tests"npm run watch-testnpm run test -- --grep="sessionStore test"Reviewer Checklist:
Tests