This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Optimize check for updates #9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could cause periodic jank after the first 2 minutes, and then again every hour after that Fix #9996
bsclifton
approved these changes
Jul 16, 2017
| @@ -131,17 +131,16 @@ var requestVersionInfo = (done, pingOnly) => { | |||
| if (!platformBaseUrl) throw new Error('platformBaseUrl not set') | |||
|
|
|||
| // Get the daily, week of year and month update checks | |||
| var lastCheckYMD = AppStore.getState().toJS().updates['lastCheckYMD'] || null | |||
| const state = AppStore.getState() | |||
| var lastCheckYMD = state.getIn(['updates', 'lastCheckYMD']) || null | |||
There was a problem hiding this comment.
Could you update this to use the default value format? ex:
var lastCheckYMD = state.getIn(['updates', 'lastCheckYMD'], null)
might as well make the variables const too instead of var 😄
There was a problem hiding this comment.
thanks, addressed here: 05781e4
There was a problem hiding this comment.
Merged it all the way up to 0.17.x but obviously no respin for that, just merged it up for the sake of easier merges if anything else changes.
|
Looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could cause periodic jank after the first 2 minutes, and then again every hour after that
Fix #9996
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests