This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
fix(eip1559): fix broken keyring handling legacy brave seeds #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
approved these changes
Sep 13, 2021
onyb
force-pushed
the
h/brave-legacy-seeds
branch
from
dce8be3
to
e7d1844
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#18052
TODO
@brave/eth-keyring-controller.QA test plan
Primer: Wallets created with Crypto Wallets Version 1.0.26 or earlier use legacy Brave seeds. The test plan only relates to transaction/message signing. See this Wiki article for details on the key derivation scheme.
Before starting the QA, you need to restore legacy 24-word seeds into the wallet. Please ping me privately if you need one with pre-loaded funds.