Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Commit

Permalink
don’t unregister guest events on crash
Browse files Browse the repository at this point in the history
  • Loading branch information
bridiver committed Sep 20, 2017
1 parent 0a0782e commit 79787d9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions lib/browser/guest-view-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ let supportedWebViewEvents = [
'did-navigate-in-page',
'security-style-changed',
'close',
'crashed',
'gpu-crashed',
'plugin-crashed',
'will-destroy',
Expand Down Expand Up @@ -69,7 +68,7 @@ const registerGuest = function (guest, embedder) {
return

let forceSend = false
if (['destroyed', 'crashed', 'did-detach', 'will-detach'].includes(event)) {
if (['destroyed', 'did-detach', 'will-detach'].includes(event)) {
delete guests[tabId]
forceSend = true
}
Expand Down
1 change: 0 additions & 1 deletion lib/renderer/web-view/guest-view-internal.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ var WEB_VIEW_EVENTS = {
'did-navigate': ['url', 'isRendererInitiated'],
'did-navigate-in-page': ['url', 'isMainFrame'],
'close': [],
'crashed': [],
'gpu-crashed': [],
'plugin-crashed': ['name', 'version'],
'will-destroy': [],
Expand Down

0 comments on commit 79787d9

Please sign in to comment.