Merge pull request #312 from brave/browser-laptop-issue-8574

don’t unregister guest events on crash
brave · Sep 20, 2017 · c25adf8 · c25adf8
1 parent a6da379
commit c25adf8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/browser/guest-view-manager.js b/lib/browser/guest-view-manager.js
@@ -19,7 +19,6 @@ let supportedWebViewEvents = [
   'did-navigate-in-page',
   'security-style-changed',
   'close',
-  'crashed',
   'gpu-crashed',
   'plugin-crashed',
   'will-destroy',
@@ -69,7 +68,7 @@ const registerGuest = function (guest, embedder) {
         return
 
       let forceSend = false
-      if (['destroyed', 'crashed', 'did-detach', 'will-detach'].includes(event)) {
+      if (['destroyed', 'did-detach', 'will-detach'].includes(event)) {
         delete guests[tabId]
         forceSend = true
       }

diff --git a/lib/renderer/web-view/guest-view-internal.js b/lib/renderer/web-view/guest-view-internal.js
@@ -17,7 +17,6 @@ var WEB_VIEW_EVENTS = {
   'did-navigate': ['url', 'isRendererInitiated'],
   'did-navigate-in-page': ['url', 'isMainFrame'],
   'close': [],
-  'crashed': [],
   'gpu-crashed': [],
   'plugin-crashed': ['name', 'version'],
   'will-destroy': [],