Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Commit

Permalink
also handle favIconUrl because that is what is in the chrome tabs api…
Browse files Browse the repository at this point in the history
…. Keeping faviconUrl for backward compatibility

auditors @bbondy @darkdh
  • Loading branch information
bridiver committed May 11, 2017
1 parent 0289fc1 commit c81548c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion atom/browser/api/atom_api_web_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2506,7 +2506,8 @@ void WebContents::OnTabCreated(const mate::Dictionary& options,
}

std::string favicon_url;
if (options.Get("faviconUrl", &favicon_url)) {
if (options.Get("faviconUrl", &favicon_url) ||
options.Get("favIconUrl", &favicon_url)) {
content::FaviconStatus status;
status.valid = true;
status.url = GURL(favicon_url);
Expand Down

1 comment on commit c81548c

@darkdh
Copy link
Member

@darkdh darkdh commented on c81548c Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.