Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Configure tor subprocess to listen on custom port #530

Closed
riastradh-brave opened this issue Mar 13, 2018 · 3 comments
Closed

Configure tor subprocess to listen on custom port #530

riastradh-brave opened this issue Mar 13, 2018 · 3 comments
Assignees

Comments

@riastradh-brave
Copy link
Contributor

To avoid conflicting with default tor configuration and with the Tor Browser, we should run the tor subprocess (of #473) with a custom socks port number that is not likely to conflict. The tor daemon uses 9050 by default, and the Tor Browser uses 9150 by default, so maybe we should use 9250. Ideally, we could use a different number for release/beta/dev builds so that developers can run (say) brave-beta with Tor support at the same time as developing it.

This is a short-term stop-gap until we have a nice way to set the socks proxy address only after the tor daemon has launched (which we will want for brave/browser-laptop#12936 unless we implement #469 first), and to cause Tor tabs to give meaningful feedback to users when tor is still launching rather than either failing cryptically or falling back to no proxy.

@bridiver
Copy link
Collaborator

in browser-laptop you could write different tor rc files by env using webpack

@riastradh-brave
Copy link
Contributor Author

Rather than futz with a torrc file, we can just pass all the options by command-line arguments to the tor process, as in https://github.com/riastradh-brave/muon/tree/riastradh-tor-port (or, commit riastradh-brave@3d64084).

@riastradh-brave
Copy link
Contributor Author

This is being done in #473 now.

@bsclifton bsclifton added this to the next tor build milestone Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants