This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Pass socks port, data directory to tor subprocess #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no need to rebase because the conflict comes from my WIP commit |
darkdh
force-pushed
the
tor_browser_context
branch
from
01a1e94 to
5af2423
Compare
darkdh
reviewed
Mar 28, 2018
| cmdline.AppendArg("--DataDirectory"); | ||
| cmdline.AppendArg(datadir); | ||
| } | ||
| launchopts.kill_on_parent_death = true; |
There was a problem hiding this comment.
this should be guarded by #if defined(OS_LINUX), I will do changes
and all the platforms will have https://github.com/brave/muon/pull/473/files#diff-df5c427fd693f9ebb2e5952cf0e9c8c7R248 to ensure the child process is terminated when parent is down
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS NOT ACTUALLY TO BE MERGED! The same semantic changes are to be replayed on top of @darkdh's work to use a utility process rather than LaunchProcess.
Adds option
tor_data_dirand adjusts parsing of optiontor_proxy, and passes arguments down to the tor program so that tor will run in the right data directory and listen on the right socks port and not pick up any torrc in /etc or whatever.Addresses #530.