This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Cherry-pick "Save a copy when advancing to dependent GIF and WebP animation frames" #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Jan 19, 2017
| @@ -620,7 +620,7 @@ diff --git a/chrome/common/chrome_paths_mac.mm b/chrome/common/chrome_paths_mac. | |||
| index d0bbbf72ff0e356e424dc280eeb1441c990b5770..8e96ea5706f87ea98ba55fcb583b16a8035fa903 100644 | |||
There was a problem hiding this comment.
I've been seeing these as well, but we can commit them separately to isolate any problems?
bridiver
reviewed
Jan 19, 2017
| @@ -0,0 +1,2443 @@ | |||
| diff --git a/base/BUILD.gn b/base/BUILD.gn | |||
There was a problem hiding this comment.
this file doesn't look correct to me. It seems to have changes from things outside of webkit
bridiver
reviewed
Jan 19, 2017
| @@ -2349,6 +2349,19 @@ index 82775974231274e6639751139f5c7bc9bbfaad25..8aca09939d20cc48cfa85c507fdea17c | |||
| readonly attribute long long lastModified; | |||
|
|
|||
| // Non-standard APIs | |||
| diff --git a/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp b/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp | |||
There was a problem hiding this comment.
this also seems wrong because it should be in filter.patch
…mation frames" https://chromium.googlesource.com/chromium/src.git/+/3a38c33c398189620281ad19a0f8e5b7f6ac3e69 must pick these commits in order first and do some proper modification 1. https://chromium.googlesource.com/chromium/src/+/605fa62ea2c9ac2924ff08f21106775d412bed5b 2. https://chromium.googlesource.com/chromium/src/+/3fd7c79eea0cb0f981a73b1264568366214f229e 3. https://chromium.googlesource.com/chromium/src/+/78115b26dfafd0fca676ac33caabd3aa8b43ecf4 4. https://chromium.googlesource.com/chromium/src/+/69969af74bfff920f5fdcc2aa547ea4af2d477d2 should be removed when upgrading to chromium 55 fix brave/browser-laptop#6656 Auditors: @bbondy, @bridiver, @bsclifton
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chromium.googlesource.com/chromium/src.git/+/3a38c33c398189620281ad19a0f8e5b7f6ac3e69
must pick these commits in order first and do some proper modification
should be removed when upgrading to chromium 55
fix brave/browser-laptop#6656
Auditors: @bbondy, @bridiver, @bsclifton